Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash of the dump tool #75

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

mrbean-bremen
Copy link
Member

  • this was a regression due to incomplete refactoring

Also fixed a deprecation warning.

- this was a regression due to incomplete refactoring
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4b23b82) 89.66% compared to head (507c5e4) 89.69%.
Report is 1 commits behind head on main.

Files Patch % Lines
dicom_validator/dump_dcm_info.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   89.66%   89.69%   +0.03%     
==========================================
  Files          15       15              
  Lines        1625     1630       +5     
==========================================
+ Hits         1457     1462       +5     
  Misses        168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrbean-bremen mrbean-bremen merged commit 649aace into pydicom:main Jan 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants