Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set coordinates to real symbols #170

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

set coordinates to real symbols #170

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
40981cd
domain coordinates must be real
e-moral-sanchez Jun 14, 2024
cfe4abd
Merge branch 'master' into real_coord
e-moral-sanchez Oct 13, 2024
892d9f5
add attribute real coordinates tests
e-moral-sanchez Oct 13, 2024
bd2e0e5
add attribute real=true to symbols
e-moral-sanchez Nov 29, 2024
6846529
add attribute real=True everywhere where the coordinates symbols are …
e-moral-sanchez Nov 29, 2024
9e16b29
fix calculation of jacobian
e-moral-sanchez Nov 29, 2024
4d765e6
fix mapping detection of variables
e-moral-sanchez Nov 29, 2024
51fc728
pass attribute real in mapping tests
e-moral-sanchez Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sympde/topology/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,8 @@ def __new__(cls, name, dim, min_coords, max_coords):
raise ValueError("Min coordinates must be smaller than max")

coord_names = 'x1:{}'.format(dim + 1)
coordinates = symbols(coord_names) # [MCP 24.07.2024] we should be able to pass real=True but requires additional testing as it breaks some calls to TerminalExpr

coordinates = symbols(coord_names, real=True)

# Choose which type to use:
# a) if dim <= 3, use Line, Square or Cube;
Expand Down
2 changes: 1 addition & 1 deletion sympde/topology/tests/test_gallery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from sympy import Tuple
from sympy import symbols

x1, x2, x3 = symbols('x1, x2, x3')
x1, x2, x3 = symbols('x1, x2, x3', real=True)

from sympde.topology import Interval, ProductDomain, InteriorDomain, Domain
from sympde.topology import Line, Square, Cube, NCubeInterior
Expand Down