Update stencil2coo kernels for shifts > 1
#442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oarray() works for StencilMatrix in 1D. A unit test (test_stencil_matrix_1d_toarray) can be found in test_stencil_matrix.py
yguclu
reviewed
Sep 26, 2024
…atrix_1d_serial_toarray and test_stencil_matrix_2d_serial_toarray instead. Changed the index generation for the 2D and 3D kernels in stencil2coo_kernels.py
yguclu
requested changes
Sep 27, 2024
yguclu
changed the title
stencil2coo kernels for shifts > 1
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
yguclu
reviewed
Sep 27, 2024
yguclu
approved these changes
Sep 27, 2024
max-models
added a commit
that referenced
this pull request
Oct 1, 2024
Fix the indexing in all kernels in `stencil2coo_kernels.py` so that the method `toarray` works for `StencilMatrix` objects in 1D/2D/3D with `shift` larger than 1. The unit tests for `toarray` in `test_stencil_matrix.py` have been parametrized to run with `shift` values of 1 and 2. --------- Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the indexing in all kernels in
stencil2coo_kernels.pyso that the methodtoarrayworks forStencilMatrixobjects in 1D/2D/3D withshiftlarger than 1.The unit tests for
toarrayintest_stencil_matrix.pyhave been parametrized to run withshiftvalues of 1 and 2.