Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqrt option to diagonal method of stencil/block matrices #434

Merged
merged 14 commits into from
Sep 27, 2024

Conversation

max-models
Copy link
Contributor

Corresponds to commit 121215d in stefan-psydac.

@max-models max-models marked this pull request as ready for review September 18, 2024 09:20
psydac/linalg/stencil.py Outdated Show resolved Hide resolved
psydac/linalg/block.py Outdated Show resolved Hide resolved
psydac/linalg/block.py Show resolved Hide resolved
psydac/linalg/stencil.py Show resolved Hide resolved
psydac/linalg/stencil.py Outdated Show resolved Hide resolved
max-models and others added 5 commits September 18, 2024 12:13
Co-authored-by: Yaman Güçlü <yaman.guclu@ipp.mpg.de>
Co-authored-by: Yaman Güçlü <yaman.guclu@ipp.mpg.de>
Co-authored-by: Yaman Güçlü <yaman.guclu@ipp.mpg.de>
Co-authored-by: Yaman Güçlü <yaman.guclu@ipp.mpg.de>
@yguclu yguclu changed the title Add sqrt option for diagonal in stencil and block matrices. Add sqrt optional argument to diagonal method of stencil/block matrices. Sep 18, 2024
@yguclu yguclu changed the title Add sqrt optional argument to diagonal method of stencil/block matrices. Add sqrt optional argument to diagonal method of stencil/block matrices Sep 18, 2024
@yguclu yguclu changed the title Add sqrt optional argument to diagonal method of stencil/block matrices Add sqrt option to diagonal method of stencil/block matrices Sep 18, 2024
psydac/linalg/block.py Outdated Show resolved Hide resolved
psydac/linalg/stencil.py Outdated Show resolved Hide resolved
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test for the new option somewhere?

@max-models
Copy link
Contributor Author

No, there isn't. Should I include one in psydac/linalg/tests/test_linalg.py?

@yguclu
Copy link
Member

yguclu commented Sep 25, 2024

No, there isn't. Should I include one in psydac/linalg/tests/test_linalg.py?

Yes please!

psydac/linalg/tests/test_linalg.py Outdated Show resolved Hide resolved
psydac/linalg/tests/test_linalg.py Outdated Show resolved Hide resolved
@yguclu yguclu merged commit 5ff3884 into pyccel:devel Sep 27, 2024
7 checks passed
max-models added a commit that referenced this pull request Oct 1, 2024
---------

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants