Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test commutativity of de Rham diagram with knot multiplicity > 1 #365

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Test commutativity of de Rham diagram with knot multiplicity > 1 #365

merged 2 commits into from
Dec 7, 2023
+74 −33

Conversation

vcarlier
Copy link
Contributor

@vcarlier vcarlier commented Dec 6, 2023 •
edited by yguclu
Loading

  • Add multiplicity to the parametrization of the unit tests in test_commutativity_projections.py and test_commutativity_projections_dual.py;
  • Relax the tolerance of the tests in test_commutativity_projections_dual.py (alternatively, more quadrature points could be used).

Fixes #350.

@vcarlier vcarlier requested a review from yguclu December 6, 2023 16:06
@vcarlier vcarlier linked an issue Dec 6, 2023 that may be closed by this pull request
Test commutativity of de Rham diagram with knot multiplicity > 1 #350
Closed
@yguclu
And newline to end of file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
98fb3f7
@yguclu yguclu changed the title Solve issue #350 (Test commutativity of de Rham diagram with knot multiplicity > 1) Test commutativity of de Rham diagram with knot multiplicity > 1 Dec 6, 2023
@yguclu yguclu merged commit 96ef438 into devel Dec 7, 2023
@yguclu yguclu deleted the solve_issue_350 branch December 7, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yguclu yguclu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test commutativity of de Rham diagram with knot multiplicity > 1
2 participants
@vcarlier @yguclu