-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make KroneckerLinearSolver
a subclass of LinearOperator
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguclu
changed the title
Reorganize LinearSolver classes
MakeOct 11, 2023
KroneckerLinearSolver
a subclass of LinearOperator
yguclu
changed the title
Make
Make Oct 11, 2023
KroneckerLinearSolver
a subclass of LinearOperator
KroneckerLinearSolver
a subclass of LinearOperator
yguclu
reviewed
Oct 11, 2023
yguclu
reviewed
Oct 11, 2023
yguclu
requested changes
Oct 11, 2023
…into linearsolver_update
yguclu
requested changes
Oct 19, 2023
yguclu
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressing issue #333, we make
KroneckerLinearSolver
subclassLinearOperator
instead ofLinearSolver
in order to be able to use fast solvers of mass matrices of logical domains together with otherLinearOperator
objects.This update further includes:
test_kron_direct_solver.py
BlockDiagonalSolver
class. It did not provide any significant advantage over using aBlockLinearOperator
instead.DirectSolver(LinearSolver)
class. It's two subclasses now directly subclassLinearSolver
.solve()
methods of allLinearSolver
subclasses as well asKroneckerLinearOperator.solve()
don't taketransposed
as optional argument anymore. Instead, propertranspose()
methods have been implemented creating new objects, as is the case forLinearOperator
subclasses.