Skip to content

Commit

Permalink
code review suggestion in the parent yml workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
santacodes committed Jul 24, 2024
1 parent 5afccee commit 9571750
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/test_on_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,14 @@ jobs:
run: uv pip install nox[uv]

- name: Test template generation
run: |
nox -s template-tests
run: nox -s template-tests

- name: Test project
run: |
nox -s project-tests
run: nox -s project-tests

- name: Run coverage tests
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
run: python -m nox -s coverage
run: nox -s coverage

- name: Upload coverage report
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12'
Expand All @@ -76,8 +74,6 @@ jobs:
steps:
- name: Check out pybamm-cookiecutter repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v5
Expand All @@ -89,7 +85,7 @@ jobs:
run: python -m pip install nox

- name: Check if the documentation can be built
run: python -m nox -s docs
run: nox -s docs

generated_project_tests:
needs: [template_test]
Expand All @@ -115,8 +111,7 @@ jobs:
run: python -m pip install cookiecutter pipx

- name: Generate a project using cookiecutter
run: |
cookiecutter . --no-input
run: cookiecutter . --no-input

- name: Install nox and test generated project
working-directory: ./pybamm_example_project
Expand Down

0 comments on commit 9571750

Please sign in to comment.