Hackathon July 2023 #351
Merged
Hackathon July 2023 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… + no-rain-nwp case
…patial correlation).
This allows some flexibility for when we consider the radar rainfall field to contain "no rain", since there will usually be some clutter present even when it's dry. The same does not hold for NWP, since there is no clutter there. This also introduces the new utility function blending.utils.check_norain
-Precipiation and noise cascade are recomposed before extrapolation
-Both fields are advected
-They are decomposed again
This removes the loss of power in the smallest scales due to the interpolation needed for the
semilagrangian advection.
In addition computational cost is reduced because the number of
extrapolation is greatly reduced.
…t grid cells instead of the maximum per grid cell in NWP
…_nr_rainy_cells_nwp function
…olation in case of not subtimesteps
- blending.utils.check_norain - load NWP - No rain cases
RubenImhoff
reviewed
Mar 27, 2024
dnerini
reviewed
Apr 9, 2024
|
I made some changes which should (hopefully) fix the issues that came from the tests. @ladc, which tests did you still want to add? We might be good to go after that. |
|
The tests on Ubuntu fail due to a problem with uploading the Codecov report - not sure what is causing it, but it seems unrelated to the PR. |
|
yes I agree, we can ignore the failing test in the context of this PR. If @ladc has no further comments or changes to add, I think we can merge it! |
dnerini
approved these changes
Apr 23, 2024
RubenImhoff
approved these changes
Apr 24, 2024
|
Thanks everyone for helping with this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings all developments made during the July 2023 pySTEPS-hackathon at the RMIB.
Many thanks to all contributors: @ladc, @RubenImhoff, Simon De Kock and Ricardo Reinoso-Rondinel.
The work was focussed on the STEPS blending routine.
NEW FEATURES
REFACTORING (all linked with #332)
This removes the loss of power in the smallest scales due to the interpolation needed for the semilagrangian advection.
In addition computational cost is reduced because the number of extrapolation is greatly reduced.
BUGFIXES