BUG: Truncate mediabox and cropbox values with > 4 points. #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan6419846
added
the
needs-discussion
|
Given the ongoing discussions in #2991, I am going to put this on hold for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2991
I confirmed that this fixes the read issue with the PDF where I experienced the original issue. I've been relatively conservative about allowing bad rectangle values and limited this to just mediabox/cropbox. If we felt good about generically handling rectangles with too many points, it would be easy to do so in
RectangleObjectinstead.I'm not certain the test I wrote is particularly good, it's just hacking the mediabox/cropbox to the value I see in the exception. I'd love to upload the original PDF as an example, but it contains customer information. That said, I believe I can reproduce this bad file using pypdf (and pypdf is the source of the original bad file), so I'll follow up in the related issue if I can reproduce and fix the write side error.