-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit width mode for variable page sizes #447
Comments
Today I faced this same problem and tracked it back to this issue and corresponding commit. Reverting the changes made in that commit makes Zathura able to render different sized pages correctly again, but reinstates the issues originally reported (inconsistent page padding in some pages and fit commands fitting to largest image in the document). Not sure what the course of action should be but personally I'd like Zathura to go back on that change and be able to render pages of different sizes without cropping. Maybe we could find other ways to fix the issues in the initial report. Here's a before and after of reverting the change: |
related to #436 Im still having this issue using 0.5.6 (OS Arch Linux)
my current workaround is downgrading to
|
For now, please revert the code so that it displays full (instead of cropped) variable sized pages! Or add a "mode" (specified using a command-line option or a key binding) that uses old-behaviour rendering. A solution might be that each page has its own scale (retaining page's aspect ratio) to make all pages have the same width, resulting in no gaps between pages. |
The aforementioned commit does indeed break documents with mixed page sizes completely. Before (zathura 0.5.6 with the faulty commit reverted): After (zathura 0.5.6, no patches): Sample document: https://www.st.com/resource/en/datasheet/stm32h743vi.pdf As you can see, the only differences between Papers and zathura's old behavior are:
Otherwise, Papers renders all pages at the same scale, within in the same cell width, and all automatic zoom modes ("fit page", "fit width", "automatic") account for the largest bounding box, both in single and dual page modes. In light of all of this, I concur with agguser: the change should be reverted, and the behavior can be refined from there to match other readers. |
I am getting this issue on 0.5.8 |
I have a similar problem with webcomics that are meant to be read with no gaps. I use I searched and found a lot of closed issues and commits about the varying page size problem including some in August and December, but still have it on the last version:
So is this issue (while being older) still the one to follow for this problem? |
Any update?, I'm still seeing the issue when loading a PDF with a few pages that are rather large (like it's a A4 PDF with a few images that are huge (relatively), thus zathura renders the A4 pages too small to be seen, if this is not the issue to comment this on please tell me and I can make another one. |
This issue ought to be the cause. |
Maybe while fixing this issue we should also enhance Zathura with #724 |
This issue is a duplicate. |
On GitLab by @helixoid on Feb 6, 2024, 06:46
I have some books (especially One Piece Manga) which has variable page sizes(several portrait and some landscape/dual-page-spreads) and when I press "s" it adjusts the document according to the width of page in landscape mode, at least it did before not now because of the page cropping issue.
I want it to adjust the document fit on per page basis like how Okular does.
I really love this program and not really a fan of all the kde dependencies that come with okular.
I also don't know how make zathura prevent scrolling to the next page when using mouse or touchpad one solution could be to display one page at a time and one change the page when pressed pagedown key and not the mouse scroll wheel.
And manga pages(dual-page-spreads) with different page sizes and getting cropped and some of the information is not displayed.
The text was updated successfully, but these errors were encountered: