Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Support: Deprecations #397

Closed
shehi opened this issue Jan 4, 2025 · 1 comment
Closed

PHP 8.4 Support: Deprecations #397

shehi opened this issue Jan 4, 2025 · 1 comment

Comments

@shehi
Copy link

shehi commented Jan 4, 2025

Following deprecation warnings popped up during package:discover operation in a Laravel project:

[2025-01-04 20:19:26] local.WARNING: Pusher\Pusher::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/Pusher.php on line 63  
[2025-01-04 20:19:26] local.WARNING: Pusher\Pusher::build_auth_query_params(): Implicitly marking parameter $auth_timestamp as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/Pusher.php on line 283  
[2025-01-04 20:19:26] local.WARNING: Pusher\Pusher::authorizeChannel(): Implicitly marking parameter $custom_data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/Pusher.php on line 887  
[2025-01-04 20:19:26] local.WARNING: Pusher\Pusher::socketAuth(): Implicitly marking parameter $custom_data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/Pusher.php on line 952  
[2025-01-04 20:19:26] local.WARNING: Pusher\Pusher::socket_auth(): Implicitly marking parameter $custom_data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/Pusher.php on line 960  
[2025-01-04 20:19:26] local.WARNING: Pusher\PusherInterface::socketAuth(): Implicitly marking parameter $custom_data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/PusherInterface.php on line 133  
[2025-01-04 20:19:26] local.WARNING: Pusher\PusherInterface::socket_auth(): Implicitly marking parameter $custom_data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/pusher/pusher-php-server/src/PusherInterface.php on line 232 

Fully compliant PHP 8.4 release would be great! Thanks.

@it-can
Copy link
Contributor

it-can commented Jan 5, 2025

There is a pr to fix this
#396

@shehi shehi closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants