Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup all occurances of domain names and ip addresses and naming of #46

Open
binarymist opened this issue Feb 22, 2021 · 0 comments
Open

Cleanup all occurances of domain names and ip addresses and naming of #46

binarymist opened this issue Feb 22, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@binarymist
Copy link
Member

We could change all occurances of sutIp to hostname, but what would make the most sense is to just combine:
sutIp, sutPort, sutProtocol from the job file into sutUrlOrigin

We should also be using URL:
@binarymist binarymist added the good first issue Good for newcomers label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarymist