Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Make usb an optional dependency for Windows ARM #240

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

AndrewLuGit
Copy link
Contributor

Makes the node-usb package an optional dependency, since it cannot be installed on Windows ARM. This allows the extension to run on Windows ARM computers. Making node-usb an optional dependency should still install the package on other operating systems.

Reference: #230

Copy link
Member

@Rocky14683 Rocky14683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM i trust him, i have no idea how this thing work

@AndrewLuGit AndrewLuGit merged commit 222f90a into develop Dec 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants