Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix welcome webview checkboxes #237

Merged

Conversation

meisZWFLZ
Copy link
Contributor

Resolves #235

Previously the welcome webview checkboxes wouldn't do anything. This fixes that.

Known edge case

The webview will not reflect changes to settings directly from the settings UI after it has been opened.
This is rare and largely cosmetic, so it should be fine to leave.

@meisZWFLZ
Copy link
Contributor Author

meisZWFLZ commented Oct 7, 2024

oh actually the better fix would be to rename the settings in package.json:

In the settings UI, your configuration key will be used to namespace and construct a title. Though an extension can contain multiple categories of settings, each setting of the extension must still have its own unique key. Capital letters in your key are used to indicate word breaks. For example, if your key is gitMagic.blame.dateFormat, the generated title for the setting will look like this:

Blame: Date Format

https://code.visualstudio.com/api/references/contribution-points#Configuration-schema

But idk how'd that would affect user's current configs, so I think I won't do that.

Copy link
Contributor

@AndrewLuGit AndrewLuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@AndrewLuGit AndrewLuGit merged commit baa3b31 into purduesigbots:develop Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Welcome Page can't be disabled
2 participants