[PE-37297]: Added support for amazon 2023 in redhat.pp manifest file #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
2 times, most recently
from
8149e5e to
076abee
Compare
donoghuc
previously requested changes
Dec 19, 2023
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
from
076abee to
83d9680
Compare
|
Could you add a commit to bump beaker-hostgenerator in acceptance/Gemfile to ~> 2? Thank you! |
mhashizume
requested changes
Dec 21, 2023
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
2 times, most recently
from
d7fd990 to
f59acf3
Compare
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
from
f59acf3 to
ff5c8ae
Compare
joshcooper
reviewed
Jan 2, 2024
|
Let's wait to merge this until this issue is resolved and builds are passing CI again puppetlabs/facter#2661 |
joshcooper
previously requested changes
Jan 5, 2024
bastelfreak
reviewed
Jan 5, 2024
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
from
ff5c8ae to
7de615d
Compare
mhashizume
previously requested changes
Jan 8, 2024
There was a problem hiding this comment.
Ran this through the experimental pipeline and it looks good! https://jenkins-platform.delivery.puppetlabs.net/view/__experimental%20automatic/job/experimental_auto_puppetlabs-puppet-agent-module_intn-sys_pa-acceptance_7-nightly_to_8-nightly-adhoc/1/
Would you be able to squash your two commits into one please?
Optimized Amazon linux 2023 support code & tests
span786
force-pushed
the
PE-37297-4-add-amazon-linux-2023-to-puppet-agent-module-puppet-acceptance
branch
from
7de615d to
d5ad156
Compare
|
Commits have been squashed into one |
span786
dismissed stale reviews from donoghuc, joshcooper, and mhashizume
Implemented the requested review
joshcooper
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.