Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - (MAINT) PDK Update #668

Merged
merged 1 commit into from
Jan 10, 2024
Merged

pdksync - (MAINT) PDK Update #668

merged 1 commit into from
Jan 10, 2024

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Dec 21, 2023

(MAINT) PDK Update
pdk version: 3.0.0

@Ramesh7 Ramesh7 requested review from bastelfreak, deric and a team as code owners December 21, 2023 04:56
@Ramesh7 Ramesh7 force-pushed the pdksync_maint-pdk-update branch 3 times, most recently from 94c0203 to a49842f Compare December 21, 2023 07:54
@Ramesh7 Ramesh7 force-pushed the pdksync_maint-pdk-update branch from a49842f to 2639572 Compare December 21, 2023 07:55
@@ -23,6 +23,7 @@ group :development do
gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false
gem "facterdb", '~> 1.18', require: false
gem "metadata-json-lint", '~> 3.0', require: false
gem "puppetlabs_spec_helper", '~> 6.0', require: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that pinned to an older version on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, even I wondered earlier but when I did backtraces I found it DevX team updated with older version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deric deric merged commit 9e873f4 into main Jan 10, 2024
5 of 7 checks passed
@deric deric deleted the pdksync_maint-pdk-update branch January 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants