(PUP-11593) Gentoo: Fix systemd service provider

[bastelfreak]

Systemd is available on Gentoo since a long time (although Gentoo supports multiple init systems). This change marks the provider as default for Gentoo.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[joshcooper]

Hi @bastelfreak could you rebase on main and resolve conflicts?

[bastelfreak]

@joshcooper updated it

[joshcooper]

If you're on Gentoo and don't have systemd, will this provider be incorrectly chosen, because it has a higher specificity than the usual gentoo provider?

puppet/lib/puppet/provider/service/gentoo.rb

Line 14 in 03b3df3

confine 'os.name' => :gentoo

Or does puppet exclude the systemd provider and default to gentoo because the systemctl command isn't available and the confine resolves to false?

[bastelfreak]

the confine resolves to false and the provider is excluded.

[joshcooper]

Sorry forgot to mention could you add a test like

puppet/spec/unit/provider/service/systemd_spec.rb

Lines 166 to 171 in 03b3df3

	it "should be the default provider on LinuxMint#{ver}" do
	allow(Facter).to receive(:value).with('os.family').and_return(:debian)
	allow(Facter).to receive(:value).with('os.name').and_return(:LinuxMint)
	allow(Facter).to receive(:value).with('os.release.major').and_return("#{ver}")
	expect(provider_class).to be_default
	end

Also if you want this in 7.x, please submit a backport PR to that branch (since it relies on legacy facts)

[bastelfreak]

added a test, let me know it that's fine for you. After it's merged I will raise a PR for the 7.x branch.