Skip to content

Commit

Permalink
Add syslog as runtime dependency
Browse files Browse the repository at this point in the history
The syslog gem moves from default gems to a normal gem in Ruby 3.4. It
raises the following warning on Ruby 3.3.5:

```
lib/puppet/util/command_line.rb:14: warning: syslog was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add syslog to your Gemfile or gemspec to silence this warning.
```
  • Loading branch information
bastelfreak committed Oct 24, 2024
1 parent c64829f commit e2962f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ group(:features) do
# requires native ldap headers/libs
# gem 'ruby-ldap', '~> 0.9', require: false, platforms: [:ruby]
gem 'puppetserver-ca', '~> 2.0', require: false
gem 'syslog', '~> 0.1.1', require: false, platforms: [:ruby]
gem 'CFPropertyList', ['>= 3.0.6', '< 4'], require: false
end

Expand Down
5 changes: 4 additions & 1 deletion puppet.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency('CFPropertyList', ['>= 3.0.6', '< 4'])
end

if platform == 'x64-mingw32' || platform == 'x86-mingw32'
if Gem::Platform::WINDOWS.include?(spec.platform) || Gem::Platform::WINDOWS.any? { |p| Gem::Platform.match_gem?(Gem::Platform.new(p)) }
# ffi 1.16.0 - 1.16.2 are broken on Windows
spec.add_runtime_dependency('ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2')
spec.add_runtime_dependency('minitar', '~> 0.9')
else
# don't depend on syslog on jruby, it requires extensions
spec.add_runtime_dependency('syslog', '~> 0.1.2') unless RUBY_PLATFORM == "java"
end
end

0 comments on commit e2962f7

Please sign in to comment.