New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Add note to update the puppetlabs_spec_helper lint whenever it is changed here #601

Merged

gavindidrichsen merged 1 commit into main from lint_note

Oct 21, 2024

Member

david22swan commented Oct 21, 2024 •

edited

Loading

In order to ensure that our lint testing remains in step we must keep these two files in sync with eachother:

Checklist

🟢 Spec tests.
Manually verified.


          (maint) Add note to update the puppetlabs_spec_helper lint whenever i…

fdea7f9

…t is change here

In order to ensure that our lint testing remains in step we must keep these two files in sync with eachother:
- https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/rake_tasks.rb#L124
- https://github.com/puppetlabs/pdk-templates/blob/d9e6478ff7730a8ce072ce0c1d36a9b79f05ba2c/config_defaults.yml#L69

david22swan added bug maintenance labels

david22swan requested a review from a team as a code owner

October 21, 2024 09:09

gavindidrichsen approved these changes

View reviewed changes

Contributor

gavindidrichsen left a comment

Thanks @david22swan !

gavindidrichsen merged commit 8842cf7 into main

3 checks passed

gavindidrichsen deleted the lint_note branch

October 21, 2024 09:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug maintenance