Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace archived ruby vscode extension #561

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

jay7x
Copy link
Contributor

@jay7x jay7x commented Feb 20, 2024

Summary

rebornix.Ruby VS Code extension repo was archived on Aug 1, 2023 (https://github.com/rubyide/vscode-ruby?tab=readme-ov-file#deprecated). Shopify.ruby-lsp is recommended instead.

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

`rebornix.Ruby` is archived on Aug 1, 2023 (https://github.com/rubyide/vscode-ruby?tab=readme-ov-file#deprecated).
`Shopify.ruby-lsp` is recommended instead.
@jay7x jay7x requested a review from a team as a code owner February 20, 2024 15:02
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay7x LGTM. As noted, this is now the recommended LSP for ruby development.

@jordanbreen28 jordanbreen28 merged commit 0f7378b into puppetlabs:main Feb 20, 2024
6 checks passed
@jay7x jay7x deleted the patch-1 branch March 9, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants