Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1693) - Remove deprecated codecov gem #556

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

the codecov gem is deprecated, and no longer required in
puppetlabs_spec_helper. We should remove this from the pdk-templates
configu defaults, as it has stopped receiving updates and is restricting
us on the versions of simplecov we can consume.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

the codecov gem is deprecated, and no longer required in
puppetlabs_spec_helper. We should remove this from the pdk-templates
configu defaults, as it has stopped receiving updates and is restricting
us on the versions of simplecov we can consume.
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner January 24, 2024 15:49
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit 1ac3168 into main Jan 24, 2024
5 checks passed
@gavindidrichsen gavindidrichsen deleted the CAT-1693-remove_codecov_gem branch January 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants