Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1606) - Adding gem group for release_pre #540

Merged

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Nov 23, 2023

Summary

We have multiple use cases where we are installing all gems every time which also lead to installing old gems or conflicts, so creating release_prep for releasing the module.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@Ramesh7 Ramesh7 requested a review from a team as a code owner November 23, 2023 02:59
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 6916572 into main Nov 23, 2023
3 of 4 checks passed
@david22swan david22swan deleted the CAT-1606-update-gemfile-template-with-release-gem-group branch November 23, 2023 09:17
@cocker-cc
Copy link
Contributor

Since this PR pdk validate states:

Your Gemfile lists the gem puppet-strings (~> 4.0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.

Your Gemfile lists the gem puppetlabs_spec_helper (~> 6.0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants