(CDPE-6574) Add Puppet logo and change title and fix styling of Authentication component #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
CDPE-6148/Change-authentication-component-title-size
branch
from
412bc05 to
55f7d21
Compare
- Imported the SCSS stylesheet into the index.js file to ensure it gets bundled by Webpack. - This change resolves the problem where the Authentication component's styling was not being applied due to the stylesheet not being bundled.
petergmurphy
force-pushed
the
CDPE-6148/Change-authentication-component-title-size
branch
3 times, most recently
from
a2f6d49 to
38915d1
Compare
petergmurphy
changed the title
petergmurphy
changed the title
petergmurphy
changed the title
petergmurphy
changed the title
sean-mckenna
requested changes
Mar 25, 2024
CHANGELOG.md
Outdated
|
|
||
| - [Logo] Fix Authentication component styling issue. This change resolves the problem where the Authentication component's | ||
| styling was not being applied due to the stylesheet not being bundled. (by [@petergmurphy](https://github.com/petergmurphy)) | ||
| - [Logo] Change the title of the Authentication component from a `h5` to a `h3` element. (by [@petergmurphy](https://github.com/petergmurphy)) |
There was a problem hiding this comment.
You can probably combine this into one changelog statement
Suggested change
| - [Logo] Change the title of the Authentication component from a `h5` to a `h3` element. (by [@petergmurphy](https://github.com/petergmurphy)) | |
| - [Authentication] description here. (by [@petergmurphy](https://github.com/petergmurphy)) |
|
Does this render the new cd4pe logo when the product prop is |
|
Seems to render the new cd4pe product logo fine when I run the server locally:
|
petergmurphy
force-pushed
the
CDPE-6148/Change-authentication-component-title-size
branch
2 times, most recently
from
7207e16 to
8496056
Compare
petergmurphy
changed the title
petergmurphy
force-pushed
the
CDPE-6148/Change-authentication-component-title-size
branch
from
8496056 to
a203d50
Compare
added 2 commits
March 27, 2024 18:41
- This modification ensures consistency with the Figma design documentation's styling. - Changed the Authentication title from a `h5` to a `h3` element.
petergmurphy
force-pushed
the
CDPE-6148/Change-authentication-component-title-size
branch
from
a203d50 to
195c186
Compare
petergmurphy
changed the title
sean-mckenna
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
(CDPE-6574) Add standalone Puppet logo
(CDPE-6574) Change Authentication title to match Figma design
h5to ah3element.(MAINT) Fix Authentication component styling bundling issue
bundled by Webpack.
styling was not being applied due to the stylesheet not being bundled.
Screenshot of proposed changes
New standalone Puppet logo (second from the right):
Before title style change:
After title style change: