(CDPE-6335) Move trailing button after input text field

[owenbeckles]

Description of proposed changes

Move the trailing button icon element to after the text input field in the Input component. This change fixes a bug that was causing the next input in a form to direct to the trailing button instead of the text input field after pressing TAB from the previous input field.

Screenshot of proposed changes

[sean-mckenna]

The change looks good, I tested locally and im seeing the tab order the way we now expect it. With the auto release github action now working on main, can you add to the CHANGELOG and bump the react-components package to a new patch version? You can see the CONTRIBUTION guideline here - https://github.com/puppetlabs/design-system/blob/main/CONTRIBUTING.md.

[owenbeckles]

The change looks good, I tested locally and im seeing the tab order the way we now expect it. With the auto release github action now working on main, can you add to the CHANGELOG and bump the react-components package to a new patch version? You can see the CONTRIBUTION guideline here - https://github.com/puppetlabs/design-system/blob/main/CONTRIBUTING.md.

Yeah of course! Kinda unrelated, I ran into a bit of an issue earlier in the ticket, the node version is currently 12 which required me to have Python2 (which isn't supported by homebrew anymore, so I had to install through pyenv) before installing node 12. I know there are probably a lot of out of date dependencies that actively rely on node 12, but are there any plans to update the project's node version?

[sean-mckenna]

I dont think I had the same issue with Node 12 and python2, I have python3 installed on my local and dont have any issues. How are you managing your node version? I would recommend using nvm - https://github.com/nvm-sh/nvm. You can switch between node versions really easily with it. But yes we will need to look at upgrading the node version soon.

[owenbeckles]

I dont think I had the same issue with Node 12 and python2, I have python3 installed on my local and dont have any issues. How are you managing your node version? I would recommend using nvm - https://github.com/nvm-sh/nvm. You can switch between node versions really easily with it. But yes we will need to look at upgrading the node version soon.

Hmm, I actually already use nvm, I ran into the issue when I tried to nvm install 12 and it told me that I needed Python2. I already had Python3 installed at the time

[sean-mckenna]

I dont think I had the same issue with Node 12 and python2, I have python3 installed on my local and dont have any issues. How are you managing your node version? I would recommend using nvm - https://github.com/nvm-sh/nvm. You can switch between node versions really easily with it. But yes we will need to look at upgrading the node version soon.

Hmm, I actually already use nvm, I ran into the issue when I tried to nvm install 12 and it told me that I needed Python2. I already had Python3 installed at the time

Try run npm use in the root directory of the repo. It should install version 12.4.0.