Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes: PIM unit test panic, accidentally committed verbose logs in TestAccPIMRoleManagementPolicies #3956

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Feb 17, 2025

The unit test workflow step was missing from the repo's branch protection rules and a failing test made it in. It's only a test issue, though.

Also, a small fix for overly verbose CI test logs.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (68c1a11) to head (8483a2a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
+ Coverage   57.29%   57.50%   +0.20%     
==========================================
  Files          80       82       +2     
  Lines       12725    13078     +353     
==========================================
+ Hits         7291     7520     +229     
- Misses       4873     4983     +110     
- Partials      561      575      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@thomas11 thomas11 changed the title Remove accidentally committed verbose logs from TestAccPIMRoleManagementPolicies Test fixes: PIM unit test panic, accidentally committed verbose logs in TestAccPIMRoleManagementPolicies Feb 20, 2025
@thomas11 thomas11 enabled auto-merge (squash) February 20, 2025 15:21
@thomas11 thomas11 merged commit 73833a7 into master Feb 20, 2025
23 checks passed
@thomas11 thomas11 deleted the tkappler/ci branch February 20, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants