Skip to content

Commit

Permalink
Remove retired security.AdvancedThreatProtection from AppService exam…
Browse files Browse the repository at this point in the history
…ple (#3938)

Fixes #3926
  • Loading branch information
thomas11 authored Feb 10, 2025
1 parent e779660 commit c7c1d06
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
7 changes: 0 additions & 7 deletions examples/appservice/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import * as pulumi from "@pulumi/pulumi";

import * as insights from "@pulumi/azure-native/insights";
import * as resources from "@pulumi/azure-native/resources";
import * as security from "@pulumi/azure-native/security";
import * as sql from "@pulumi/azure-native/sql";
import * as storage from "@pulumi/azure-native/storage";
import * as web from "@pulumi/azure-native/web";
Expand All @@ -19,12 +18,6 @@ const storageAccount = new storage.StorageAccount("sa", {
kind: storage.Kind.StorageV2,
});

new security.AdvancedThreatProtection("atp", {
settingName: "current",
resourceId: storageAccount.id,
isEnabled: true,
});

const appServicePlan = new web.AppServicePlan("asp", {
resourceGroupName: resourceGroup.name,
kind: "App",
Expand Down
3 changes: 2 additions & 1 deletion examples/appservice/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"@types/node": "latest"
},
"dependencies": {
"@pulumi/pulumi": "^3.0.0"
"@pulumi/pulumi": "^3.0.0",
"@pulumi/azure-native": "latest"
}
}
5 changes: 3 additions & 2 deletions examples/examples_nodejs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,7 @@ func TestRecoveryServicesProtectedItemTs(t *testing.T) {
Dir: filepath.Join(getCwd(t), "recoveryservices-protecteditem"),
// Backing up protected items increases `protectedItemsCount` in policy and container,
// and adds `AzureBackupProtected` to the item.
ExpectRefreshChanges: true,
PreviewCommandlineFlags: []string{"--diff"},
ExpectRefreshChanges: true,
})

integration.ProgramTest(t, &test)
Expand All @@ -330,6 +329,8 @@ func getJSBaseOptions(t *testing.T) integration.ProgramTestOptions {
Dependencies: []string{
"@pulumi/azure-native",
},
// Show the diff instead of just the non-actionable error: no changes were expected but changes were proposed"
PreviewCommandlineFlags: []string{"--diff"},
})

return baseJS
Expand Down

0 comments on commit c7c1d06

Please sign in to comment.