From a84eb1f8ab7c9b2c5eeb2dfc1656d5c13a146de2 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 22:48:57 -0800 Subject: [PATCH 1/7] Attempt to install dependency on new Ubuntu CI images --- .github/workflows/validate-wasm-grammar-prs.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index 7a43b0e6d2..67406f45b6 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -12,6 +12,8 @@ jobs: validate: runs-on: ubuntu-latest steps: + - name: Install build dependencies + run: apt-get update && apt-get install -y libx11-dev - name: Checkout the Latest Code uses: actions/checkout@v4 with: From 3c7611ab73694b4a0d5d4d854cccd0e08f376758 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 22:51:36 -0800 Subject: [PATCH 2/7] Temporary CI change just to test the workflow --- .github/workflows/validate-wasm-grammar-prs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index 67406f45b6..f2114ea995 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -5,8 +5,8 @@ name: Validate WASM Grammar PR Changes on: pull_request: - paths: - - '**.wasm' + # paths: + # - '**.wasm' jobs: validate: From 0b888930e554470dda60a723622fc655a8eb8976 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 23:13:02 -0800 Subject: [PATCH 3/7] Add `sudo` --- .github/workflows/validate-wasm-grammar-prs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index f2114ea995..d622da3ed0 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Install build dependencies - run: apt-get update && apt-get install -y libx11-dev + run: sudo apt-get update && sudo apt-get install -y libx11-dev - name: Checkout the Latest Code uses: actions/checkout@v4 with: From 57f1d1a574f28a521c7af70687177ab4b45f54a7 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 23:21:23 -0800 Subject: [PATCH 4/7] Use practically the whole damn list from the other CI job --- .github/workflows/validate-wasm-grammar-prs.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index d622da3ed0..c1f412ae43 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -13,6 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Install build dependencies + run: apt-get update && apt-get install -y git python3 python3-pip make gcc g++ libx11-dev libxkbfile-dev pkg-config libsecret-1-dev run: sudo apt-get update && sudo apt-get install -y libx11-dev - name: Checkout the Latest Code uses: actions/checkout@v4 From 1fb2232c2860951ca86e61d7b1f751c2d94d5e2c Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 23:31:06 -0800 Subject: [PATCH 5/7] (oops) --- .github/workflows/validate-wasm-grammar-prs.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index c1f412ae43..2d5b8fc96e 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -14,7 +14,6 @@ jobs: steps: - name: Install build dependencies run: apt-get update && apt-get install -y git python3 python3-pip make gcc g++ libx11-dev libxkbfile-dev pkg-config libsecret-1-dev - run: sudo apt-get update && sudo apt-get install -y libx11-dev - name: Checkout the Latest Code uses: actions/checkout@v4 with: From 9e69b3f02b87ba32a465daa3cb6dc73511d8f65c Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sat, 11 Jan 2025 23:41:32 -0800 Subject: [PATCH 6/7] (I do not learn from mistakes) --- .github/workflows/validate-wasm-grammar-prs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index 2d5b8fc96e..a0575740ae 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Install build dependencies - run: apt-get update && apt-get install -y git python3 python3-pip make gcc g++ libx11-dev libxkbfile-dev pkg-config libsecret-1-dev + run: sudo apt-get update && sudo apt-get install -y git python3 python3-pip make gcc g++ libx11-dev libxkbfile-dev pkg-config libsecret-1-dev - name: Checkout the Latest Code uses: actions/checkout@v4 with: From ec0492bc27df991b81bf82eb430ac790f5f6d53f Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Sun, 12 Jan 2025 00:07:21 -0800 Subject: [PATCH 7/7] =?UTF-8?q?It=20worked=20=E2=80=94=20re-imposing=20CI?= =?UTF-8?q?=20constraint?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/validate-wasm-grammar-prs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-wasm-grammar-prs.yml b/.github/workflows/validate-wasm-grammar-prs.yml index a0575740ae..56edb7b44a 100644 --- a/.github/workflows/validate-wasm-grammar-prs.yml +++ b/.github/workflows/validate-wasm-grammar-prs.yml @@ -5,8 +5,8 @@ name: Validate WASM Grammar PR Changes on: pull_request: - # paths: - # - '**.wasm' + paths: + - '**.wasm' jobs: validate: