-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to install dependency on new Ubuntu CI images #1192
Conversation
I'm temporarily removing constraints on the “Validate WASM Grammar PR Changes” CI job just to confirm that it gets further into the process with this step added. Switching to draft until I can back out this change. |
OK, got this job working again; re-imposed the constraint so that the “validate WASM grammar PR changes” CI job doesn't run for this change. You can look through the Actions tab's history to verify that there was a successful run of that job on this PR. Any other CI failures are out of scope for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit tempted to install the actual complete list of packages from the other CI job, it'd be a bit wasteful but reduce the chance, however small, of a difference affecting one job and not the other.
Also: Might be nice to clean up the commit history.
BOTH OPTIONAL. Approved as-is (and/or with the above suggestions done, assuming no new stuff beside that -- can re-review if there are changes beyond scope of this review feedback).
Squash and merge will take care of the commit history. The ones I left out were the ones where I could be sure they were related to other tasks. |
Attempt to install dependencies on new Ubuntu CI images
Some CI jobs are complaining about X11…
…so let's make sure it's installed.
Hoping it's just this easy!