Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to install dependency on new Ubuntu CI images #1192

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

savetheclocktower
Copy link
Contributor

Some CI jobs are complaining about X11…

make: Entering directory '/home/runner/work/pulsar/pulsar/node_modules/keyboard-layout/build'
  CXX(target) Release/obj.target/keyboard-layout-manager/src/keyboard-layout-manager.o
In file included from ../src/keyboard-layout-manager.cc:1:
../src/keyboard-layout-manager.h:7:10: fatal error: X11/Xlib.h: No such file or directory
    7 | #include <X11/Xlib.h>
      |          ^~~~~~~~~~~~
compilation terminated.

…so let's make sure it's installed.

Hoping it's just this easy!

@savetheclocktower savetheclocktower marked this pull request as draft January 12, 2025 06:51
@savetheclocktower
Copy link
Contributor Author

I'm temporarily removing constraints on the “Validate WASM Grammar PR Changes” CI job just to confirm that it gets further into the process with this step added. Switching to draft until I can back out this change.

@savetheclocktower
Copy link
Contributor Author

OK, got this job working again; re-imposed the constraint so that the “validate WASM grammar PR changes” CI job doesn't run for this change. You can look through the Actions tab's history to verify that there was a successful run of that job on this PR.

Any other CI failures are out of scope for this PR.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit tempted to install the actual complete list of packages from the other CI job, it'd be a bit wasteful but reduce the chance, however small, of a difference affecting one job and not the other.

Also: Might be nice to clean up the commit history.

BOTH OPTIONAL. Approved as-is (and/or with the above suggestions done, assuming no new stuff beside that -- can re-review if there are changes beyond scope of this review feedback).

@savetheclocktower
Copy link
Contributor Author

Also: Might be nice to clean up the commit history.

Squash and merge will take care of the commit history.

The ones I left out were the ones where I could be sure they were related to other tasks. xvfb and ffmpeg are related to capturing video of functional tests; squashfs is related to AppImages; et cetera. If this causes problems later I'll be happy to be assigned the PR to fix it. :)

@savetheclocktower savetheclocktower marked this pull request as ready for review January 13, 2025 00:09
@savetheclocktower savetheclocktower merged commit 1ec04f6 into master Jan 13, 2025
101 of 103 checks passed
@savetheclocktower savetheclocktower deleted the fix-additional-ci-grumpiness branch January 13, 2025 00:10
savetheclocktower added a commit that referenced this pull request Jan 14, 2025
Attempt to install dependencies on new Ubuntu CI images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants