Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing: publish with release.origin if defined #1249

Closed
wants to merge 1 commit into from

Conversation

dguglielmi
Copy link

If the user provided the Origin value when creating the release, it is preferable to retain this value.

@quba42
Copy link
Collaborator

quba42 commented Mar 4, 2025

@dguglielmi By default, if the repo contains a Release, then the origin field of that Release will be used. Only if there is no Release, or if publish_upstream is set to False, do we revert to origin="Pulp 3",. This is a desired fallback to legacy pulp_deb behavior under specific circumstances.

Is there any chance you have the publish_upstream_release_fields flag set to False on your repository? If yes, just set it to True and you will get the behavior you want.

@dguglielmi
Copy link
Author

I understand. I created a new repository, and publish_upstream_release_fields is set to false (which is strange—I need to check why it's not true by default). So I thought interacting here would be a good approach. You can go ahead and close this MR. Thanks for the guidance!

@quba42
Copy link
Collaborator

quba42 commented Mar 5, 2025

I understand. I created a new repository, and publish_upstream_release_fields is set to false (which is strange—I need to check why it's not true by default).

That is strange, the default should definitely be True, see:
https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/models/repository.py#L65

@quba42 quba42 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants