Add permissive sync setting for less lenient validation of Release files #1222
Conversation
hstct
force-pushed
the
add_permissive_sync
branch
from
044e806 to
39e878f
Compare
hstct
force-pushed
the
add_permissive_sync
branch
3 times, most recently
from
1dbfaae to
e10e998
Compare
| if "codename" in release_dict: | ||
| d_content.content.codename = release_dict["Codename"] | ||
| if "suite" in release_dict: | ||
| d_content.content.suite = release_dict["Suite"] |
There was a problem hiding this comment.
As long as we do not do anything else in the ifs, this can be simplified to
| if "codename" in release_dict: | |
| d_content.content.codename = release_dict["Codename"] | |
| if "suite" in release_dict: | |
| d_content.content.suite = release_dict["Suite"] | |
| d_content.content.codename = release_dict.get("Codename") | |
| d_content.content.suite = release_dict.get("Suite") |
Unless d_content.content.codename = None is not the same as not setting it at all 🤔
This would be an additional change to the original code, so I am OK, if this is ignored (for now).
There was a problem hiding this comment.
Unless d_content.content.codename = None is not the same as not setting it at all
Yea, this is the problem and will require further changes.
| fake_file_path = tmp_path / "Release" | ||
| artifact._fake_file_path = fake_file_path |
There was a problem hiding this comment.
Not fully sure what this does 😅
Have you considered using mock_open for the file-handler mocking?
There was a problem hiding this comment.
I test the actual file I/O behavior here. It will create an actual tmp file with the open method. I could mock this but it might hide issues that only occur with real file operations.
hstct
force-pushed
the
add_permissive_sync
branch
from
e10e998 to
4bacd59
Compare
hstct
force-pushed
the
add_permissive_sync
branch
from
4bacd59 to
0e9cbe1
Compare
No description provided.