Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Verilator 5 and update other dependencies #76

Closed
wants to merge 3 commits into from
Closed

Switch to Verilator 5 and update other dependencies #76

wants to merge 3 commits into from

Conversation

RickLuiken
Copy link
Contributor

Fixes #6 and #75.

I changed the way the Makefile works to compile both the sv and c++ files with verilator. Moreover, I did the following:

  • Added a no-timing flag to the verilator command
  • Changed the c++ std from c++14 to c++20 (recommended by verilator)
  • Changed the spike fesvr version to a more recent one to support GCC13 (see this PR). Unfortunately, this newer version requires at least c++17, which is not compatible with verilator 4. Therefore, verilator 4 does not work with this PR!
  • Updated the dockerfile. It now uses ubuntu 22.04. It builds verilator 5.006 from the source and now uses the same verible version as the CI.

To test it, I did the following:

  • Run verilator tests using docker
  • Run banshee tests using docker

I do not have access to modelsim, so I couldn't test that.

If you have any comments/questions, please let me know!

@RickLuiken
Copy link
Contributor Author

Hi, just to let you know, the CI failed because it uses the old container with verilator 4. It should work if the new container is used, but I don't know how to test this in the CI. Could you help me with this?

@colluca
Copy link
Collaborator

colluca commented Jan 11, 2024

Thanks for the contribution @RickLuiken.

We currently have an issue with the CI which we are solving. After that I will try it out with the Docker container update and let you know.

Best,
Luca

@colluca
Copy link
Collaborator

colluca commented Jul 8, 2024

Hi @RickLuiken, once again thanks for the contribution. I reduced the changes and split them into two separate PRs, one of which has already been merged.

I will close this PR in favour of #158 where we will follow on the upgrade to Verilator 5.

Best,
Luca

@colluca colluca closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different Verible version in Docker container and Github CI linting stage
2 participants