-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sw: Switch to non-recursive Make build system #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM! The issue in #147 was also resolved this way👍 |
Does the tutorial need to be updated? |
I will follow with a tutorial update after merging #71, since it also affects the benchmarking utilities. |
colluca
added a commit
that referenced
this pull request
Aug 22, 2024
colluca
added a commit
that referenced
this pull request
Aug 22, 2024
colluca
added a commit
that referenced
this pull request
Aug 22, 2024
colluca
added a commit
that referenced
this pull request
Aug 23, 2024
colluca
added a commit
that referenced
this pull request
Aug 23, 2024
colluca
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a shift from the recursive Make paradigm to a non-recursive Make build system for Snitch software. The advantages of a non-recursive implementation are well-known.
The shift was triggered by a limitation which emerged in #147. As the dependency between an app and the snRuntime is not represented in the Makefiles (they are distinct subdirectories which are built recursively), the runtime has to be manually built before an application can be built. This dependency can be trivially encoded in a non-recursive implementation.
This PR preserves all the functionalities of the old build system, though the exact commands and API may have changed, namely:
make sw
,make clean-sw
)make gemm
,make runtime
,make tests
)The latter three, which are needed to implement extensive regression tests, are used e.g. in
target/snitch_cluster/sw/apps/blas/gemm/test
.It further improves on code reuse, sharing common parts of Makefiles as much as possible.
The current implementation imposes a limitation: all software apps must have a unique name. It is not possible therefore to e.g. have a
dnn/gemm
andblas/gemm
. This condition is currently satisfied. Note that the limitation can be removed, but we chose not to tackle this at the moment to simplify the implementation.