sw: Multi-cluster runtime improvements #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischeti
force-pushed
the
multi-cluster-rt
branch
6 times, most recently
from
50be571 to
a8fe8ae
Compare
fischeti
requested review from
colluca,
viv-eth,
paulsc96 and
lucabertaccini
as code owners
colluca
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Since snitch_cluster_defs.h is also auto-generated now, perhaps we want to just merge it with snitch_cluster_cfg.h. I believe the previous idea was to just separate the auto-generated defines to a single place, and everything else derived from it. But I think it's not too relevant and we can just merge them to possibly simplify the codebase.
Further minor comments follow.
target/snitch_cluster/sw/runtime/common/snitch_cluster_defs.h.tpl
Outdated
Show resolved
Hide resolved
colluca
force-pushed
the
multi-cluster-rt
branch
2 times, most recently
from
069a505 to
433d286
Compare
colluca
force-pushed
the
multi-cluster-rt
branch
from
433d286 to
df6c738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the snitch runtime when when the snitch cluster is used as a dependency in a multi-cluster system.
Changes
snitch_cluster_defs.hwith the number of clustersnr_quadrantsin configuration, which is obsolete in my opinion and was never actually used anywhere.