Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DMCPY instruction for multi-channel iDMA #65

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

LuziLucia
Copy link
Collaborator

The DMCPY instruction didn't return the correct transfer id for other channels than channel 0. This made the test program wait for a transfer id that would never be returned by DMSTAT.
It was fixed by adding the indexing to next_id. The indexing was also added to the ready signal idma_fe_req_ready.

@thommythomaso thommythomaso self-assigned this Jan 7, 2025
Copy link
Collaborator

@thommythomaso thommythomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thommythomaso thommythomaso merged commit 73033b6 into master Jan 7, 2025
26 checks passed
@thommythomaso thommythomaso deleted the luzil/fix-dmcpy-multi-chan branch January 7, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants