Adding sortable call number to the output for bib items #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the locator to find the location of the item
Including lcsort to do most of the legwork, but utilizing some custom code to pick up the items lcsort misses
carolyncole
force-pushed
the
normal_call
branch
from
e7455a4 to
35a215e
Compare
carolyncole
added a commit
to pulibrary/firestone_locator
that referenced
this pull request
Sep 16, 2019
…rent locator generates Some may be more accurate than the old code, based on the fact that the normalized version from voyager does not look normalized. Added a PR into mrc_liberation pulibrary/bibdata#560 for adding the sortable call no. Once that exists we need to change the SQL table, and use the new fields and new table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the locator to find the location of the item
Including lcsort to do most of the legwork, but utilizing some custom code to pick up the items lcsort misses
See pulibrary/lcsort#21 for a list of items lcsort misses.
This should fix: pulibrary/voyager_helpers#104