[WIP] Live Event App #11
Conversation
jguz-pubnub
force-pushed
the
feature/live-event-app
branch
from
7e13593 to
f03bb1a
Compare
jguz-pubnub
force-pushed
the
feature/live-event-app
branch
3 times, most recently
from
a628be0 to
d581074
Compare
jguz-pubnub
force-pushed
the
feature/live-event-app
branch
3 times, most recently
from
689fe90 to
e20e5d1
Compare
live-event-app/live-event-app-UITests/LiveEventAppUITests.swift
Outdated
Show resolved
Hide resolved
live-event-app/live-event-app-UITests/LiveEventAppUITests.swift
Outdated
Show resolved
Hide resolved
live-event-app/live-event-app-UITests/LiveEventAppUITests.swift
Outdated
Show resolved
Hide resolved
live-event-app/live-event-app/FPSDebug/Charts/UIFPSLinearChart.swift
Outdated
Show resolved
Hide resolved
| streamViewController.didMove(toParent: self) | ||
|
|
||
| messageListContainerViewController.view.translatesAutoresizingMaskIntoConstraints = false | ||
| streamViewController.view.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
what do you think about making setup for streamViewController then for messageListContrainerViewController? In that way we can make separate functions and remove comments
There was a problem hiding this comment.
I removed a comment. Both messageListContainerViewController and streamViewController depend on each other. For instance, messageListContainerViewController top anchor is bounded to the bottom anchor of the streamViewController in portrait mode, so there's always a dependency between them. I checked your suggestion and the attempt to split applying constraints into two separate functions produced more code than it was originally.
There was a problem hiding this comment.
Thats true that they depends on each other but it is not obstacle to create one setup then another, when activating constraints only in one place we have dependency
streamViewController.view.bottomAnchor.constraint(equalTo: messageListContainerViewController.view.topAnchor)
and this line requires both views in the same views hierarchy. Sometimes more code is cleaner then too long function like this one.
| streamViewController.view.leadingAnchor.constraint(equalTo: view.leadingAnchor), | ||
| streamViewController.view.trailingAnchor.constraint(equalTo: view.trailingAnchor), | ||
| streamViewController.view.topAnchor.constraint(equalTo: view.topAnchor), | ||
| streamViewController.view.bottomAnchor.constraint(equalTo: messageListContainerViewController.view.topAnchor) |
There was a problem hiding this comment.
maybe it is good idea to have segregated arrays for message and stream constraints and concatenate them in this big ones for portrait and landscape.
There was a problem hiding this comment.
I tried to resolve it and described it in this comment.
|
|
||
| // Enables PubNub logging to the Console | ||
| // PubNub.log.levels = [.all] | ||
| // PubNub.log.writers = [ConsoleLogWriter()] |
There was a problem hiding this comment.
imho it should be enabled in final version
jguz-pubnub
force-pushed
the
feature/live-event-app
branch
2 times, most recently
from
54a5b27 to
189e0c0
Compare
jguz-pubnub
force-pushed
the
feature/live-event-app
branch
from
189e0c0 to
11fdb81
Compare
No description provided.