Multiple wl types #261
Merged
Multiple wl types #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flat rate whitelist support [SG-280]
MightOfOaks
approved these changes
Jun 3, 2024
|
The whitelist on the current name-minter needs to be removed before migration to avoid type mismatches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple whitelist types.
These changes update the way whitelists are stored and referenced inside the
name-minter. I've updated the relevant code to store a struct of{address, whitelist_type}to avoid two different storage locations. This pattern could be used to add additional whitelist types in the future, however I feel like there should be a top-down re-arch of WLs and they should be normalized across all places the functionality is used (such asmarketplace).