-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SG-1051] Names renewal #252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasiov
force-pushed
the
tasiov/sg-1051-names-renewal
branch
from
December 18, 2023 22:01
0ba011f
to
716e36f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 68.29% 69.70% +1.40%
==========================================
Files 25 26 +1
Lines 1432 1690 +258
==========================================
+ Hits 978 1178 +200
- Misses 454 512 +58 ☔ View full report in Codecov by Sentry. |
tasiov
requested review from
shanev,
jhernandezb,
jason-c-child and
MightOfOaks
January 2, 2024 18:45
tasiov
force-pushed
the
tasiov/sg-1051-names-renewal
branch
from
January 2, 2024 21:26
02c4cdf
to
47d9a70
Compare
tasiov
force-pushed
the
tasiov/sg-1051-names-renewal
branch
from
January 2, 2024 21:30
47d9a70
to
5f9ef40
Compare
* minor updates * ignore lint * ignore lint * update schema
Flat rate whitelist support [SG-280]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Document with testing notes
The purpose of these changes is to implement a working version of Names renewal. Below are some details.
Names Marketplace Sudo Params
The following fields have been added to the Names Marketplace Sudo Params object.
Names Marketplace Messages
The following messages were added to the Names Marketplace: