Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof php version in schedules troubleshooting guide #623

Closed
wants to merge 2 commits into from

Conversation

Loki-101
Copy link
Contributor

Previous "up to" isn't specific enough now that there's only two supported versions, and I may as well use the page that's built for this exact purpose if I'm updating it.

Previous "up to" isn't specific enough now that there's only two supported versions, and I may as well use the page that's built for this exact purpose if I'm updating it.
@rowansc1 rowansc1 self-requested a review November 24, 2024 01:37
@rowansc1 rowansc1 added the enhancement New feature or request label Nov 24, 2024
rowansc1

This comment was marked as duplicate.

Copy link
Contributor

@rowansc1 rowansc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 143 is incorrect, the <> are not needed in the context you are using and should be removed.

The <> are used independently when you want to pop something out which is just a link, not an embedded link, such as in the contab guru link below.

Example:

[this page](https://pterodactyl.io/panel/1.0/updating.html#panel-version-requirements)

Thanks for your PR!

panel/1.0/troubleshooting.md Outdated Show resolved Hide resolved
@rowansc1 rowansc1 added the Please Correct Waiting for user to fix the requested issues label Nov 24, 2024
@Loki-101
Copy link
Contributor Author

Whoops, too used to markdown for Discord. I removed the <> for crontab.guru while I was at it; that was leftover from when I was sending this guide in Discord before the original PR was accepted.

@Loki-101 Loki-101 closed this by deleting the head repository Dec 11, 2024
@Loki-101
Copy link
Contributor Author

Whoops, I was cleaning up old repositories and forgot I had this PR open. I'll make a new one.

Loki-101 added a commit to Loki-101/documentation that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Please Correct Waiting for user to fix the requested issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants