-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to the documentation #553
Conversation
@PadowYT2 - Is this still something you want to merge eventually? Although it's been like 8 months lol |
Sorry, but still waiting on the opinion on the original comment |
Reverting as nodesource are now supporting their install scripts again.
This reverts commit 830d6fc.
For those playing along at home, I've been pushing builds of this to CF pages as I go along. |
Didn't realize you are pushing your changes to this PR, I guess thanks. Also, why PHP 8.3 and not 8.2? |
We wanted to get this PR finished and merged, but it touched so many different files we didn't want to work on other PRs for the other stuff and risk having to deal with the merge conflicts afterwards. We're happy to close this and open a different PR if you would prefer. PHP 8.3 is fully released and compatible with Pterodactyl. I didn't see any reason to target 8.2 when it's only in active support for another 5 months. |
I'm happy with this in its current state 👍 well done |
Every systemctl command in the documentation has sudo before, why not this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All happy with this! Just need Matt to approve and merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If PHP 8.3 is used by default, we don't need nginx-php8.1-*.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet. I like the small changes here. I don't think the table changes were strictly needed, but definitely makes the markdown easier to read.
Should be good to go when matt reviews it. Thanks for coming back to it after so long @PadowYT2!
Changes in this PR