Skip to content

Version specific packet implementation pattern #208

Version specific packet implementation pattern

Version specific packet implementation pattern #208

Triggered via pull request August 21, 2024 02:00
Status Failure
Total duration 48s
Artifacts

dotnet.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/AddResourcePackPacket.cs#L18
'AddResourcePackPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'AddResourcePackPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/DisconnectPacket.cs#L13
'DisconnectPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'DisconnectPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Login/DisconnectPacket.cs#L13
'DisconnectPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'DisconnectPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Login/EncryptionRequestPacket.cs#L14
'EncryptionRequestPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'EncryptionRequestPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/KeepAlivePacket.cs#L12
'KeepAlivePacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'KeepAlivePacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/PingPacket.cs#L12
'PingPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'PingPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/PluginMessagePacket.cs#L13
'PluginMessagePacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'PluginMessagePacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/RegistryDataPacket.cs#L13
'RegistryDataPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'RegistryDataPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/RemoveResourcePackPacket.cs#L12
'RemoveResourcePackPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'RemoveResourcePackPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build: Components/MineSharp.Protocol/Packets/Clientbound/Configuration/FeatureFlagsPacket.cs#L13
'FeatureFlagsPacket' does not implement interface member 'IPacketStatic.Read(PacketBuffer, MinecraftData)'. 'FeatureFlagsPacket.Read(PacketBuffer, MinecraftData)' cannot implement 'IPacketStatic.Read(PacketBuffer, MinecraftData)' because it does not have the matching return type of 'IPacket'.
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L5
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L5
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult.EnsureOnlyRunOnceAsyncResult(Task, bool)'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L5
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult.Task'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L5
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult.FirstInvocation'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L7
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult.GetAwaiter()'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L9
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult<TResult>'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L9
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult<TResult>.EnsureOnlyRunOnceAsyncResult(Task<TResult>, bool)'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L9
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult<TResult>.Task'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L9
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult<TResult>.FirstInvocation'
build: MineSharp.Core/Concurrency/ConcurrencyHelper.cs#L11
Missing XML comment for publicly visible type or member 'EnsureOnlyRunOnceAsyncResult<TResult>.GetAwaiter()'