Fix issue with wrong until in GitHub search
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! Would you mind extending the /tests/github/issues and /tests/github/pulls tests with a simple test case demonstrating that the dates now work as expected? |
|
The PRs and issues appearing when running tests against the master: teemtee/tmt#1645, teemtee/tmt#1644, teemtee/tmt#1648, teemtee/tmt#1650 |
Felixoid
force-pushed
the
github-until
branch
from
eb67936 to
6a1a32f
Compare
|
It was previously inconsistent with using somewhere defined local variables and somewhere not. Fixed it |
|
This PR is ready to review and merge. Since it touches the same code, I'll use it as a base for #363. |
|
Hey-hey, happy new year! A kind ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #362.
A decoupled part from #363