-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for use of env variables to set redirect URIs #173
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request! Would you mind elaborating a bit on how this would be used? Could you provide a bit more details on your scenario? |
Would this be better off filtered/hooked instead of using |
We have various dynamically generated review environments that share the same database for testing purposes. |
Thanks @StoneWaves, that makes sense. I agree with @bradkovach that this would be better implemented with a filter/hook so that the entire config can be overwritten by a different plugin in a more WordPress-y way. Because this is some very sensitive configuration, we might want to have another setting (one which would not filterable) that enables the filter (e.g. "Allow other plugins to overwrite these settings")). (Though whether or not this is useful is debatable, since another plugin could still get to this data anyway.) |
A Keeping this toggle in database has no real security benefit, since--as @psignoret mentioned--any plugin can use |
…redirect-uri-variables
0320183
to
37c8428
Compare
How's that? It's been re-written to just apply filters now, allowing another plugin to pull from environment variables. Let me know if you'd like any changes made. |
@psignoret, @bradkovach, would appreciate your input here. Is this ready for merge? |
Load redirect_uri and logout_redirect_uri from an environment variable if its set, otherwise use the value stored in the database.
This allows the redirect uris to be set dynamically for review applications without needing to change a value in the database.