feat(microsof365): Add documentation and compliance file #6195

MarioRgzLpz · 2024-12-13T16:33:16Z

Context

Write all documentation needed for a correctly set up to allow prowler scan microsoft365 and add the compliance file with the CIS 4.0 Microsoft465 Benchmark controls.

Description

Changed documentation files and fill the compliance file with all the CIS controls using generate_compliance_json_from_csv_for_cis40_microsoft365.

Checklist

Are there new checks included in this PR? No
- If so, do we need to update permissions for the provider? Please review this carefully.
Review if the code is being covered by tests.
Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
Review if backport is needed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… and a check to test if things are working properly

…new checks following CIS recommendations

…has work on it

…ly not working

…ing to be used and add more description to status extended in admincenter checks

…tests still not working

…test connection, not working

…ptions, regions and mutelist

…nant is not allowed for microsoft365 and adjust admincenter service and checks to that change

…al to those that are either manual in the CIS or cant be done using msgraph SDK

…ft365 as a new provider

…ript to generate the json from the csv file and the model for the output

…amework stats in the output

…1-documentation

github-actions · 2025-02-05T17:53:18Z

You can check the documentation for this PR here -> Prowler Documentation

docs/getting-started/requirements.md

docs/tutorials/microsoft365/create-prowler-service-principal.md

github-actions · 2025-02-05T18:14:09Z

You can check the documentation for this PR here -> Prowler Documentation

docs/tutorials/microsoft365/authentication.md

Co-authored-by: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com>

github-actions · 2025-02-05T18:52:00Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-05T18:54:55Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-05T18:59:34Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-05T19:05:48Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-05T19:43:12Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-05T19:44:30Z

You can check the documentation for this PR here -> Prowler Documentation

codecov · 2025-02-05T20:28:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (bce958b) to head (c4311f4).
Report is 19 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6195      +/-   ##
==========================================
+ Coverage   88.72%   88.74%   +0.02%     
==========================================
  Files        1200     1200              
  Lines       34608    34609       +1     
==========================================
+ Hits        30705    30713       +8     
+ Misses       3903     3896       -7

Flag	Coverage Δ
prowler	`88.74% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
prowler	`88.74% <100.00%> (+0.02%)`	⬆️
api	`∅ <ø> (∅)`

docs/index.md

docs/getting-started/requirements.md

docs/tutorials/microsoft365/create-prowler-service-principal.md

github-actions · 2025-02-10T15:16:53Z

You can check the documentation for this PR here -> Prowler Documentation

github-actions · 2025-02-10T15:17:10Z

You can check the documentation for this PR here -> Prowler Documentation

puchy22

👍

Co-authored-by: MrCloudSec <hello@mistercloudsec.com> Co-authored-by: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com>

MarioRgzLpz added 19 commits November 20, 2024 08:26

feat(microsoft365): Add new provider microsoft 365 to prowler main

210207a

feat(microsoft365): Add microsoft365 CheckReport model

9bb4329

feat(microsoft365): Add microsoft365 to provider and summary table

9a9cc9a

feat(microsoft365): Add microsoft365 as a new provider. Add a service…

a27029c

… and a check to test if things are working properly

feat(microsoft365): Fix some things so the output is correctly generated

ad1518f

feat(microsoft365): Rename users service to admincenter and add some …

4bd81de

…new checks following CIS recommendations

feat(admincenter): Finish checks and service, add metadata but still …

4564f0d

…has work on it

fix(microsoft365): Adding verify connection to m365 provider, current…

eb4e41b

…ly not working

feat(admincenter): Delete one attribute from the user that was not go…

8860895

…ing to be used and add more description to status extended in admincenter checks

feat(tests): Add service and checks tests working properly, provider …

13f6139

…tests still not working

feat(tests): Fix some microsoft tests, still not working

a18b79a

feat(microsoft365): Fix exceptions, make some changes in provider to …

68e29b6

…test connection, not working

feat(microsoft365): Finish provider and mutelist tests

ac80388

feat(microsoft365): Finish provider with test connection, finish exce…

1dccb40

…ptions, regions and mutelist

feat(microsoft365): Change service to save only one client as multite…

de10410

…nant is not allowed for microsoft365 and adjust admincenter service and checks to that change

feat(microsoft365): Adjust tests to service changes

6a8c43f

feat(microsoft365): Fill compliance with the done checks and put manu…

5a88a60

…al to those that are either manual in the CIS or cant be done using msgraph SDK

docs(microsoft365): Add all documentation related with adding microso…

6f46053

…ft365 as a new provider

feat(microsoft365): Add full cis4.0 compliance file as a json, the sc…

6a4590d

…ript to generate the json from the csv file and the model for the output

MarioRgzLpz requested review from a team as code owners December 13, 2024 16:33

MarioRgzLpz added 2 commits December 18, 2024 09:24

feat(microsoft365): Modify everything needed to add the compliance fr…

21ae7ac

…amework stats in the output

docs: Add Microsoft365 section to the docs navigation bar

239a649

Base automatically changed from PRWLR-5291-microsoft-365-mvp-development to master January 24, 2025 18:14

Merge branch 'master' into PRWLR-5506-microsoft-365-realease-version-…

7930640

…1-documentation

github-actions bot added the documentation label Feb 5, 2025

danibarranqueroo reviewed Feb 5, 2025

View reviewed changes

docs/getting-started/requirements.md Outdated Show resolved Hide resolved

danibarranqueroo reviewed Feb 5, 2025

View reviewed changes

docs/tutorials/microsoft365/create-prowler-service-principal.md Outdated Show resolved Hide resolved

chore: revision

ea2bf0f

danibarranqueroo reviewed Feb 5, 2025

View reviewed changes

docs/tutorials/microsoft365/authentication.md Outdated Show resolved Hide resolved

chore: revision

2e586e9

Co-authored-by: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com>

chore: revision

7b7454c

chore: revision

be901d0

chore: revision

d31b7b6

chore: revision

1c5f2e2

chore: revision

457d2d2

puchy22 requested changes Feb 6, 2025

View reviewed changes

MrCloudSec added 2 commits February 10, 2025 10:16

chore: revision

5d9a363

chore: revision

c4311f4

MrCloudSec requested review from puchy22, danibarranqueroo and MrCloudSec February 10, 2025 15:17

MrCloudSec approved these changes Feb 10, 2025

View reviewed changes

puchy22 approved these changes Feb 10, 2025

View reviewed changes

MrCloudSec merged commit dcb9267 into master Feb 10, 2025
12 checks passed

MrCloudSec deleted the PRWLR-5506-microsoft-365-realease-version-1-documentation branch February 10, 2025 16:13

jfagoagas pushed a commit that referenced this pull request Feb 10, 2025

feat(microsof365): Add documentation and compliance file (#6195)

45d359c

Co-authored-by: MrCloudSec <hello@mistercloudsec.com> Co-authored-by: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(microsof365): Add documentation and compliance file #6195

feat(microsof365): Add documentation and compliance file #6195

MarioRgzLpz commented Dec 13, 2024

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

codecov bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

puchy22 left a comment

feat(microsof365): Add documentation and compliance file #6195

feat(microsof365): Add documentation and compliance file #6195

Conversation

MarioRgzLpz commented Dec 13, 2024

Context

Description

Checklist

License

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

codecov bot commented Feb 5, 2025 • edited Loading

Codecov Report

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

puchy22 left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 5, 2025 •

edited

Loading