chore(directoryservice): verify only the message

prowler-cloud · Feb 5, 2025 · 68048c6 · 68048c6
1 parent 81463b6
commit 68048c6
Showing 1 changed file with 11 additions and 20 deletions.
diff --git a/prowler/providers/aws/services/directoryservice/directoryservice_service.py b/prowler/providers/aws/services/directoryservice/directoryservice_service.py
@@ -130,16 +130,13 @@ def _describe_event_topics(self, regional_client):
                                 )
                             self.directories[directory.id].event_topics = event_topics
                         except ClientError as error:
-                            if error.response["Error"]["Code"] == "ClientException":
-                                error_message = error.response["Error"]["Message"]
-                                if "is in Deleting state" in error_message:
-                                    logger.warning(
-                                        f"{directory.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
-                                    )
-                                else:
-                                    logger.error(
-                                        f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
-                                    )
+                            if (
+                                "is in Deleting state"
+                                in error.response["Error"]["Message"]
+                            ):
+                                logger.warning(
+                                    f"{directory.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
+                                )
                             else:
                                 logger.error(
                                     f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
@@ -226,16 +223,10 @@ def _get_snapshot_limits(self, regional_client):
                             ]["ManualSnapshotsLimitReached"],
                         )
                     except ClientError as error:
-                        if error.response["Error"]["Code"] == "ClientException":
-                            error_message = error.response["Error"]["Message"]
-                            if "is in Deleting state" in error_message:
-                                logger.warning(
-                                    f"{directory.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
-                                )
-                            else:
-                                logger.error(
-                                    f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
-                                )
+                        if "is in Deleting state" in error.response["Error"]["Message"]:
+                            logger.warning(
+                                f"{directory.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
+                            )
                         else:
                             logger.error(
                                 f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"