This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
Work around cancel() after complete() wrong behavior in reactive-grpc #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @bsideup and @simonbasle for the investigation work and fix! |
bsideup
reviewed
Oct 1, 2019
| // Used to transform the publisher chain into one that doesn't forward cancel() calls once it has complete()d. | ||
| private Function<? super Publisher<Tuple2<Integer, Message<byte[]>>>, ? extends Publisher<Tuple2<Integer, Message<byte[]>>>> ignoreCancelsAfterComplete() { | ||
| return Operators.lift((f, actual) -> | ||
| new CoreSubscriber<>() { |
There was a problem hiding this comment.
FTR this can be optimized by implementing both CoreSubscriber and Subscription, something like:
class NoCancelAfterCompleteSubscriber<T> implements CoreSubscriber<T>, Subscription {
@Override
public void onSubscribe(s) { actual.onSubscribe(this); }
}
return new NoCancelAfterCompleteSubscriber<>();although this is a very specific optimization can may be ignored if the performance of this part is not critical
bsideup
reviewed
Oct 1, 2019
| private Function<? super Publisher<Tuple2<Integer, Message<byte[]>>>, ? extends Publisher<Tuple2<Integer, Message<byte[]>>>> ignoreCancelsAfterComplete() { | ||
| return Operators.lift((f, actual) -> | ||
| new CoreSubscriber<>() { | ||
| AtomicBoolean completed = new AtomicBoolean(); |
There was a problem hiding this comment.
since we don't need atomic CAS operation in onComplete, you could also use volatile boolean completed = false instead of +1 allocating AtomicBoolean
ericbottard
force-pushed
the
workaround-cancel-on-input
branch
from
dc9bde9 to
2ccbbba
Compare
ericbottard
force-pushed
the
workaround-cancel-on-input
branch
from
2ccbbba to
8cab801
Compare
|
This has been merged already |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See salesforce/reactive-grpc#194