feat: proxy webhooks #607
Merged
feat: proxy webhooks #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverbaehler
force-pushed
the
feat/relabler-webhook
branch
3 times, most recently
from
405f4de to
38542bf
Compare
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
oliverbaehler
force-pushed
the
feat/relabler-webhook
branch
from
38542bf to
7bead05
Compare
prometherion
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some changes here:
pprofshould not be available always, only if specified via args. This is to prevent any leakage in production environments.Watchdog: only reconcile forCREATEandUPDATE, everything else does not matter for the labelsWebhooks: Add Webhooks to the proxy. The watchdog webhook is very primitive. We have left a lot of configuration options for the webhook in thevalues.yaml. The webhooks are not enabled by default and the watchdog webhook is a failurePolicy of ignore by default. Updating should therefor not cause any interruptionsUsing this Webhook will also resolve #530