Remove Bootstrap 4 data attributes #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
force-pushed
the
rm-bs4-data-attr
branch
from
7f0fa40 to
69a5b3e
Compare
corylown
force-pushed
the
rm-bs4-data-attr
branch
from
69a5b3e to
5eb0cca
Compare
corylown
commented
Feb 19, 2025
| @@ -22,8 +22,7 @@ | |||
| assert_select "tr[data-edit-for='#{admin_role.id}']" | |||
| assert_select 'td', /jane@example.com/ | |||
| assert_select 'td', 'Admin' | |||
| assert_select "input[type='submit'][data-behavior='destroy-user'][data-target='#{admin_role.id}']," \ | |||
| "input[type='submit'][data-behavior='destroy-user'][data-bs-target='#{admin_role.id}']" | |||
| assert_select "input[type='submit'][data-behavior='destroy-user'][data-target='#{admin_role.id}']" | |||
There was a problem hiding this comment.
these are not bootstrap targets so we should just use data-target not data-bs-target
corylown
commented
Feb 19, 2025
| @@ -27,8 +27,7 @@ | |||
| end | |||
|
|
|||
| it 'has a checkbox to enable or disable fielded search' do | |||
| expect(rendered).to have_selector 'input[data-behavior="enable-feature"][data-target="#search_fields"], ' \ | |||
| 'input[data-behavior="enable-feature"][data-bs-target="#search_fields"]' | |||
| expect(rendered).to have_selector 'input[data-behavior="enable-feature"][data-target="#search_fields"]' | |||
There was a problem hiding this comment.
these are not bootstrap targets so we should just use data-target not data-bs-target
corylown
commented
Feb 19, 2025
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| <div class="content-block carousel-block item-features"> | |||
| <% if solr_documents_features_block.documents? %> | |||
| <div id="<%= html_id %>" class="carousel" data-ride="carousel" data-interval="false"> | |||
| <div id="<%= html_id %>" class="carousel"> | |||
There was a problem hiding this comment.
these attributes are no longer needed with bootstrap 5
taylor-steve
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.