Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BC years #18

Closed
jkeck opened this issue Apr 9, 2014 · 4 comments
Closed

Add support for BC years #18

jkeck opened this issue Apr 9, 2014 · 4 comments

Comments

@jkeck
Copy link
Contributor

jkeck commented Apr 9, 2014

We have a few collections that have negative year values (Papyrus Manuscripts) that don't show up properly in the date slider. We currently remove negative years from the facet that drives the date facet, however we get reports from confused users from time to time.

I am creating this ticket as a place to discuss the feasibility of adding this support to blacklight_range_limit.

@jrochkind
Copy link
Member

Should be possible, assuming you can figure out how to make Solr deal with it.

I guess they'd be indexed in Solr as actual negative years, like you say, since the func is currently based on a Solr numeric (not date) field (and thus theoretically avail for non-date numeric data too).

Would you want to display them as "BC", or as actual negative years too? It should probably be possible to display them as "BC" on the flot chart, using flot custom formatting options. Not sure about the slider.

As a first pass, if you actually want to display them as negative numbers -- I'm not sure what would keep it from just working, actually. Try indexing negative numbers into your Solr field, I wonder if it'll just plain work. If not, I suspect there will only be minor tweaks needed to make it work.

@cbeer
Copy link
Member

cbeer commented Apr 9, 2014

(See also #17)

@atz
Copy link
Member

atz commented Apr 29, 2015

See also #34 for date support overall.

@starsplatter
Copy link

I've just hit the BC date problem for a couple of collections. Has anyone got any work in progress on this?

mejackreed added a commit that referenced this issue Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants