Allow empty parens in a string to be safely parsed #112
Conversation
|
Failures are related to wrong node version (which I have fixed in this PR) and what look like changes in upstream Blacklight handling of facet constraints rendering. Going to try to come back to that issue later |
|
|
This change allows an empty set of parens, `()`, to be in a string and to be parsed as a token. Prior to this change, and empty set of parens would be parsed as a list with no contents which could not be successfully parsed, but instead results in a error as described in projectblacklight#101. This change fixes issue projectblacklight#101.
bibliotechy
force-pushed
the
handle-empty-parens
branch
from
9886b2e
to
17973c3
Compare
|
Rebased on top of fixes introduced in #113, so this is now good to go. |
|
I think I should have rebased this first before merging it. I'm going to revert and then create a new PR with a rebased version because it looks like there are some issues with the HEAD of the main branch. |
|
Hey @bibliotechy sorry for the mess up here. I was recently given commit access to this repo and I though I would merge this PR but I messed up and didn't rebase it before hand. It failed on the main branch so I quickly reverted main back to it's original state. I recreated your PR here at #122 and I have rebased it. |
This change allows an empty set of parens,
(), to be in a string and to be parsed as a token. Prior to this change, and empty set of parens would be parsed as a list with no contents which could not be successfully parsed, but instead results in a error as described in #101.This change fixes issue #101.